Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple define to disable auto shift at startupAUTO_SHIFT_DISABLED_AT_STARTUP #14201

Merged
merged 1 commit into from
Nov 1, 2021
Merged

simple define to disable auto shift at startupAUTO_SHIFT_DISABLED_AT_STARTUP #14201

merged 1 commit into from
Nov 1, 2021

Conversation

agodinhost
Copy link

@agodinhost agodinhost commented Aug 28, 2021 •
edited
Loading

simple define to disable auto shift at startup AUTO_SHIFT_DISABLED_AT_STARTUP

Description

Simple define to change the auto shift initial state.
The current auto shift initial state is always on, with this #define we will be able to
make it disabled at startup.

#define AUTO_SHIFT_DISABLED_AT_STARTUP

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 28, 2021
@stale
Copy link

stale bot commented Oct 24, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna drashna requested a review from a team October 27, 2021 00:27
@stale stale bot removed the awaiting changes label Oct 27, 2021
@tzarc tzarc changed the base branch from master to develop November 1, 2021 22:11
tzarc
tzarc approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swapped to develop due to core changes.

@tzarc tzarc merged commit f775da9 into qmk:develop Nov 1, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@agodinhost @ptrxyz
define to AUTO_SHIFT_DISABLED_AT_STARTUP (qmk#14201)
7af4d46 
Co-authored-by: agodinhost <[email protected]>
@riannucci riannucci mentioned this pull request Aug 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agodinhost @drashna @tzarc